[WS-2756] Localise football match kick off time in Sport Header #14093
Merged
Louis-Matsika merged 10 commits intoJun 10, 2026
Conversation
hotinglok
changed the title
This reverts commit b4ef70f.
Louis-Matsika
approved these changes
Jun 9, 2026
Contributor
|
LGTM. following the testing steps shows the correct localised times 🕘 |
shayneahchoon
approved these changes
Jun 9, 2026
HarveyPeachey
approved these changes
Jun 9, 2026
| }, | ||
| "packageManager": "yarn@4.9.4" | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Github crying about eof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: WS-2756
Summary
Adds client-side localisation of match kick-off times in Sport Header component.
Storybook/full component unit tests were not added given the difficulties of mocking browser locale. As such this should be manually tested and verified as working through test assets.
Code changes
get-localised-time.tsto helpers.Testing
Cmd + shift + pand search forShow sensors.Useful Links